Jan Engelhardt <[EMAIL PROTECTED]> writes: > On Sep 5 2007 18:00, James Pearson wrote: >> >> OK, here is the patch (without the long line) against 2.6.23-rc5 - what else >> needs to be done to get it committed? > > Someone has to point out CodingStyle, so I'll ruin everyone's day now :) > Already pointed out! :) By Alexey Dobriyan.
>> +static ssize_t environ_read(struct file * file, char __user * buf, > ^ ^ > be gone these spaces. > >> + while (count > 0) { >> + int this_len, retval; >> + >> + this_len = mm->env_end - (mm->env_start + src); >> + >> + if (this_len <= 0) { >> + break; >> + } > > Be gone, braces. > > > -- Anton Arapov, <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/