On Thu, Jun 27, 2019 at 9:43 PM Paul Walmsley <paul.walms...@sifive.com> wrote: > > On Thu, 27 Jun 2019, Yash Shah wrote: > > > Reading the count register clears the interrupt signal. Currently, the > > count registers are read into 'regval' variable but the variable is > > never used. Therefore remove it. > > > > Signed-off-by: Yash Shah <yash.s...@sifive.com> > > This is a good start. Could you also add comments in the code that > describe what those reads are doing, as you did in the patch description? > Otherwise they look pretty mysterious. >
Sure, will add comments and send v2 > > - Paul
