On Fri, Jun 28, 2019 at 10:52:04AM +0800, Zorro Lang wrote: > On Thu, Jun 27, 2019 at 09:43:04PM +0000, Luis Chamberlain wrote: > > On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > > > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > > > There is no real problem merging ioends that go beyond i_size into an > > > > ioend that doesn't. We just need to move the append transaction to the > > > > base ioend. Also use the opportunity to use a real error code instead > > > > of the magic 1 to cancel the transactions, and write a comment > > > > explaining the scheme. > > > > > > > > Signed-off-by: Christoph Hellwig <h...@lst.de> > > > > > > Reading through this patch, I have a feeling it fixes the crash that > > > Zorro has been seeing occasionally with generic/475... > > > > > > Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > > > > Zorro, can you confirm? If so it would be great to also refer to > > the respective bugzilla entry #203947 [0]. > > Sure, I'll give it a test. But it's so hard to reproduce, I need long enough > time to prove "the panic's gone". > > BTW, should I only merge this single patch to test, or merge your whole > patchset > with 13 patches?
Just this one patch. --D > Thanks, > Zorro > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=203947 > > > > Luis
