Re: Linux 2.6.23-rc5 - oops

[Jeff Garzik]

Grant Wilson wrote:

Get an oops when booting this kernel:

[...]

Using git-bisect the faulty commit is

bad: [43a98f05d99205687ddf74089e79a8312c8c5f90] ata_piix: implement IOCFG bit18 
quirk

Good work bisecting!  I love git-bisect :)

The attached patch should fix things, let me know if it does not.

        Jeff



diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index e40c94f..3b8bf18 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -955,7 +955,8 @@ static int piix_broken_suspend(void)
                                DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE M500"),
                        },
                },
-               { }
+
+               { }     /* terminate list */
        };
        static const char *oemstrs[] = {
                "Tecra M3,",
@@ -1187,6 +1188,8 @@ static void piix_iocfg_bit18_quirk(struct pci_dev *pdev)
                                DMI_MATCH(DMI_PRODUCT_NAME, "M570U"),
                        },
                },
+
+               { }     /* terminate list */
        };
        u32 iocfg;