Hi,

Am Freitag, 21. Juni 2019, 20:00:17 CEST schrieb Katsuhiro Suzuki:
> This patch adds missing mdio and ethernet PHY nodes for rk3328 ASUS
> tinker board.
> 
> Signed-off-by: Katsuhiro Suzuki <katsuh...@katsuster.net>

just for my understanding, which problem does this solve?
Normally the gmac can establish connections just fine on
the rk3288 by probing the phy in the automatic way.

And I also don't see any additional properties like phy
interrupt line below.


Thanks
Heiko

> ---
>  arch/arm/boot/dts/rk3288-tinker.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi 
> b/arch/arm/boot/dts/rk3288-tinker.dtsi
> index 293576869546..3190817e8d5d 100644
> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
> @@ -117,6 +117,7 @@
>       assigned-clocks = <&cru SCLK_MAC>;
>       assigned-clock-parents = <&ext_gmac>;
>       clock_in_out = "input";
> +     phy-handle = <&phy0>;
>       phy-mode = "rgmii";
>       phy-supply = <&vcc33_lan>;
>       pinctrl-names = "default";
> @@ -127,6 +128,17 @@
>       tx_delay = <0x30>;
>       rx_delay = <0x10>;
>       status = "ok";
> +
> +     mdio0 {
> +             compatible = "snps,dwmac-mdio";
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             phy0: ethernet-phy@0 {
> +                     compatible = "ethernet-phy-ieee802.3-c22";
> +                     reg = <0>;
> +             };
> +     };
>  };
>  
>  &gpu {
> 




Reply via email to