Dave Hansen wrote:
> On Wed, 2007-08-29 at 15:20 -0700, Paul Menage wrote:
>> I'd argue that having the user's specified limit be truncated to the
>> page size is less confusing than giving an EINVAL if it's not page
>> aligned.
>
> Do we truncate mmap() values to the nearest page so to not confuse the
> user? ;)
>
I think rounding to the closest page size is a better option, but
again it can be a bit confusing. I am all for using memparse() to
parse the user input as a specification of the memory limit.
The second question of how to store it internally without truncation/
rounding is something we need to agree upon. We also need to see
how to display the data back to the user.
I chose kilobytes for two reasons
1. Several people recommended it
2. Herbert mentioned that they've moved to that interface and it
was working fine for them.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
PS: I am going off to the web to search for some CUI/CLI guidelines.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
