On Wed, Jun 12, 2019 at 3:16 PM Andrew Lunn <and...@lunn.ch> wrote: > On Wed, Jun 12, 2019 at 02:36:44PM +0200, Linus Walleij wrote:
> > Sorry for giving bad advice here on IRC... my wrong. > > > > > -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o > > > -realtek-objs := realtek-smi.o rtl8366.o rtl8366rb.o > > > +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o > > > +rtl8366-objs := realtek-smi.o rtl8366-common.o > > > rtl8366rb.o > > > > What is common for this family is not the name rtl8366 > > (there is for example rtl8369 in this family, we just haven't > > added it yet) but the common technical item is SMI. > > Hi Linus > > I was not sure about this. I thought SMI was the bus used to > communicate with the switch. It just seemed odd to call a switch > family after the bus. It is true, but as can be seen from: Documentation/devicetree/bindings/net/dsa/realtek-smi.txt it is a family of 8 switches. I think we should just have one module handling all of them for simplicity, once we get around to implementing anything else than RTL8366RB that is. It's these 8 switches that talk SMI and they have a lot in common like talking RRCP internally AFAICT. I think these switches are pretty complex on the inside, we just don't have very good documentation :/ > Anyway, if you are happy with the name realtek-smi: > > Reviewed-by: Andrew Lunn <and...@lunn.ch> Thanks! Yours, Linus Walleij
