* J. Bruce Fields ([EMAIL PROTECTED]) wrote: > On Sat, Aug 25, 2007 at 04:09:27PM +0100, Dr. David Alan Gilbert wrote: > > This patch adds the address of the client that caused an > > error in sunrpc/svc.c so that you get errors that look like: > > > > svc: 192.168.66.28, port=709: unknown version (3 for prog 100003, nfsd) > > > > I've seen machines which get bunches of unknown version or similar > > errors from time to time, and while the recent patch to add > > the service helps to find which service has the wrong version it doesn't > > help find the potentially bad client. > > Looks like a reasonable idea to me, thanks! Any objection to just > calling it "svc_printk" instead of "svc_printkerr"?
No, that's fine. > I also wonder whether these shouldn't all be dprintk's instead of > printk's. One misbehaving client could create a lot of noise in the > logs. Yeh; I wasn't going to change anything else about it; the rate limiting (that I think Neil put in a few months ago) means that any one client doesn't get too noisy - I've got something trying to do version 0 on nfs to a bunch of boxes and I do wonder why; I suspect it's just a monitoring script - but it seems better to know about it until I figure it out. I'm not going to be able to recut the patch until the weekend; do you just want to remove the 'err' in your copy and feed this to the main tree with some of the rest of your patches? Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux on Alpha,68K| Happy \ \ gro.gilbert @ treblig.org | MIPS,x86,ARM,SPARC,PPC & HPPA | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
