From: Tomer Maimon <tmaimo...@gmail.com>

commit 4e63ed6b90803eeb400c392e9ff493200d926b06 upstream.

Checking if regulator is valid before reading
NPCM ADC regulator voltage to avoid system crash
in a case the regulator is not valid.

Signed-off-by: Tomer Maimon <tmaimo...@gmail.com>
Cc: <sta...@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/iio/adc/npcm_adc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/iio/adc/npcm_adc.c
+++ b/drivers/iio/adc/npcm_adc.c
@@ -149,7 +149,7 @@ static int npcm_adc_read_raw(struct iio_
                }
                return IIO_VAL_INT;
        case IIO_CHAN_INFO_SCALE:
-               if (info->vref) {
+               if (!IS_ERR(info->vref)) {
                        vref_uv = regulator_get_voltage(info->vref);
                        *val = vref_uv / 1000;
                } else {


Reply via email to