On 03/06/2019 14:00, Anand Moon wrote: > Hi Niel, > > On Mon, 3 Jun 2019 at 14:41, Neil Armstrong <narmstr...@baylibre.com> wrote: >> >> This patch adds basic support for : >> - Amlogic G12B, which is very similar to G12A >> - The HardKernel Odroid-N2 based on the S922X SoC >> >> The Amlogic G12B SoC is very similar with the G12A SoC, sharing >> most of the features and architecture, but with these differences : >> - The first CPU cluster only has 2xCortex-A53 instead of 4 >> - G12B has a second cluster of 4xCortex-A73 >> - Both cluster can achieve 2GHz instead of 1,8GHz for G12A >> - CPU Clock architecture is difference, thus needing a different >> compatible to handle this slight difference >> - Supports a MIPI CSI input >> - Embeds a Mali-G52 instead of a Mali-G31, but integration is the same >> >> Actual support is done in the same way as for the GXM support, including >> the G12A dtsi and redefining the CPU clusters. >> Unlike GXM, the first cluster is different, thus needing to remove >> the last 2 cpu nodes of the first cluster. >> >> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> >> Reviewed-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 289 ++++++++++++++++++ >> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 82 +++++ >> 3 files changed, 372 insertions(+) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b.dtsi >> >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile >> b/arch/arm64/boot/dts/amlogic/Makefile >> index e129c03ced14..07b861fe5fa5 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts >> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts >> new file mode 100644 >> index 000000000000..161d8f0ff4f3 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts >> @@ -0,0 +1,289 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (c) 2019 BayLibre, SAS >> + * Author: Neil Armstrong <narmstr...@baylibre.com> >> + */ >> + >> +/dts-v1/; >> + >> +#include "meson-g12b.dtsi" >> +#include <dt-bindings/input/input.h> >> +#include <dt-bindings/gpio/meson-g12a-gpio.h> >> + >> +/ { >> + compatible = "hardkernel,odroid-n2", "amlogic,g12b"; >> + model = "Hardkernel ODROID-N2"; >> + >> + aliases { >> + serial0 = &uart_AO; >> + ethernet0 = ðmac; >> + }; >> +
[...] >> + >> + main_12v: regulator-main_12v { >> + compatible = "regulator-fixed"; >> + regulator-name = "12V"; >> + regulator-min-microvolt = <12000000>; >> + regulator-max-microvolt = <12000000>; >> + regulator-always-on; >> + }; >> + >> + vcc_5v: regulator-vcc_5v { >> + compatible = "regulator-fixed"; >> + regulator-name = "5V"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + regulator-always-on; > > As per odroid-n2_rev0.4_20190307 schematic its missing. > vin-supply = <&main_12v>; > > With this please add my. > Tested-by: Anand Moon <linux.am...@gmail.com> Good catch, thanks Anand. @Kevin, should I resend ? Neil > > Best Regards > -Anand >> + }; >> + >> + vcc_1v8: regulator-vcc_1v8 { >> + compatible = "regulator-fixed"; >> + regulator-name = "VCC_1V8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + vin-supply = <&vcc_3v3>; >> + regulator-always-on; >> + }; >> + [...] >> + >> +&clkc { >> + compatible = "amlogic,g12b-clkc"; >> +}; >> -- >> 2.21.0 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlo...@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic