On 03/06/2019 19:32, Vincent Guittot wrote: > On Mon, 3 Jun 2019 at 20:15, Valentin Schneider [...] > My original goal was to add a group type to classify the group but > this would have broken the current behavior whereas I only want to > move code > >> >> Also, why tag this group in update_sd_pick_busiest()? It would make more >> sense to do so in update_sg_lb_stats() like with the other sg_lb_stats >> fields: > > With your proposal below, the test is called for every groups' > statistic update whereas it is only done lastly after checking other > rules in the current code and I don't want to modify the current > behavior but only move code to set imbalance in calculate imbalance. >
Adding a new group_type would make sense. From a behavioral point of view your change is fine, but from a logical one it sits halfway between being a new stat and being a new group_type. I'd rather see a new group_type, though as you said that's a different topic than cleaning up duplicate operations. > A bigger cleanup will come in next steps > [...]
