On Fri, 24 Aug 2007 22:03:42 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote:
> Alan Cox napsal(a): > > ase, 0x80); > >> remove also the hwbase var. > >> > >>> + rebase = pci_iomap(pdev, 0, 0x80); > >>> t = readl(rebase + CNTRL_REG_OFFSET); > > > > Switch to ioread* if you are using the iomap interface. Its not a trivial > > Why, if you know it's surely a mem region (and thus you rely on it and do > ioremap)? There are many places in the kernel, where this approach is used, > e.g. > libata piix. Every single one of them is wrong. The encoding of iomap values is platform dependant. Fixed in my tree. > > > conversion and its slower and bulkier - the original ioremap was much > > better > > at least get rid of the reading the hwbase address from pci conf space, use > pci_resource_start instead. Agreed entirely - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
