Marc Dionne <marc.c.dio...@gmail.com> wrote: > > diff --git a/fs/afs/cell.c b/fs/afs/cell.c > > index 9c3b07ba2222..980de60bf060 100644 > > --- a/fs/afs/cell.c > > +++ b/fs/afs/cell.c > > @@ -387,7 +387,6 @@ static int afs_update_cell(struct afs_cell *cell) > > if (ret == -ENOMEM) > > goto out_wake; > > > > - ret = -ENOMEM; > > vllist = afs_alloc_vlserver_list(0); > > if (!vllist) > > goto out_wake; > > Looks like the intention here was to return -ENOMEM when > afs_alloc_vlserver_list fails, which would mean that the fix should > move the assignment within if (!vllist), rather than just removing it. > Although it might be fine to just return the error that came from > afs_dns_query instead, as you do in this patch.
I think I'd rather return the original error as this patch effects. I'm having a ponder on it. David
