On Tue, May 28, 2019 at 11:41:57PM +0800, YueHaibing wrote: > On 2019/5/28 22:35, Sven Van Asbroeck wrote: > > On Tue, May 28, 2019 at 10:31 AM YueHaibing <yuehaib...@huawei.com> wrote: > >> > >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set > >> > > > > checkpatch.pl errors remain: > > > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml > > ERROR: DOS line endings > > #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: > > +^Iselect REGMAP_MMIO^M$ > > This seems text/plain messages have crlf set when saved as .eml file, > > I do check my v2 patch is not crlf ending, but when save as eml file in > > my thunderbird, it becomes crlf ending.
You all need a better email client, mutt handles this just fine, it's not a problem on my system with my workflow at all :) So this patch looks fine to me from a formatting point of view. But does it do what it says it does, that's up to Sven... thanks, greg k-h
