Casey Schaufler <ca...@schaufler-ca.com> wrote:

> The change was made in commit c3300aaf95fb4 from Al Viro.

This should be in a "Fixes:" tag?

> +     fsparam_string("fsdef",         Opt_fsdefault),
>       fsparam_string("fsdefault",     Opt_fsdefault),
>       fsparam_string("fsfloor",       Opt_fsfloor),
>       fsparam_string("fshat",         Opt_fshat),

Would it be better to delete the "fsdefault" line?

Also, should all of these be prefixed with "smack"?  So:

        fsparam_string("smackfsdef",    Opt_fsdefault),
        fsparam_string("smackfsfloor",  Opt_fsfloor),
        fsparam_string("smackfshat",    Opt_fshat),     

David

Reply via email to