On Thu, 2007-08-23 at 13:41 -0700, Luck, Tony wrote: > > I have a double "hpet" entry in "available_clocksource": > > $ cat /sys/devices/system/clocksource/clocksource0/available_clocksource > > tsc hpet hpet acpi_pm jiffies > > Oops. If seems that both drivers/char/hpet.c and arch/x86_64/kernel/hpet.c > both register a clocksource named "hpet". Probably a result of bringing > back to life a long lost patch, and having someone else (John Stultz, > according > to git blame) make a similar change to a different file in the intervening > time. > > Presumably the thing to do would be merge the x86_64 specific version > into the drivers/char/hpet.c version?
Ugh. Yea. i386 has an hpet clocksource as well. We should kill the duplication, but at the moment I'm not comfortable that the driver/char/hpet.c is ok to be used for i386/x86_64 (Bob: Do you know why the shift value is only 10?). I'm a little surprised by this, as the clocksource code use to prevent duplicate named clocksources from being registered, so I'm not sure how that check got dropped. Also I'm not quite sure I see where the hard freeze is coming from. My initial reaction would be to either ifdef ia64 implementation in drivers/char/hpet.c or move the code under the ia64 arch dir until it is really usable by all arches. Bob, your thoughts? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
