On (22/08/07 13:50), Andrew Morton didst pronounce:
> On Wed, 22 Aug 2007 13:48:00 -0700
> Andrew Morton <[EMAIL PROTECTED]> wrote:
> 
> > This:
> > 
> > --- a/mm/page_alloc.c~a
> > +++ a/mm/page_alloc.c
> > @@ -2814,6 +2814,8 @@ static int __cpuinit process_zones(int c
> >     return 0;
> >  bad:
> >     for_each_zone(dzone) {
> > +           if (!populated_zone(zone))
> > +                   continue;               
> >             if (dzone == zone)
> >                     break;
> >             kfree(zone_pcp(dzone, cpu));
> > _
> > 
> > might help avoid the crash
> 
> err, make that
> 

We're already in the error path at this point and it's going to blow up.
The real problem is kmalloc_node() returning NULL for whatever reason.

> --- a/mm/page_alloc.c~a
> +++ a/mm/page_alloc.c
> @@ -2814,6 +2814,8 @@ static int __cpuinit process_zones(int c
>       return 0;
>  bad:
>       for_each_zone(dzone) {
> +             if (!populated_zone(dzone))
> +                     continue;
>               if (dzone == zone)
>                       break;
>               kfree(zone_pcp(dzone, cpu));
> _
> 
> 

-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to