On Mon, 2019-05-20 at 16:52 +0300, Leon Romanovsky wrote: > On Mon, May 20, 2019 at 06:34:49AM -0700, Joe Perches wrote: > > On Mon, 2019-05-20 at 13:16 +0000, Michal Kalderon wrote: > > > > From: Joe Perches <j...@perches.com> > > > > Sent: Monday, May 20, 2019 3:57 PM > > > > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after > > > > Fixes > > > > statement > > > > > > > > External Email > > > > > > > > ---------------------------------------------------------------------- > > > > On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote: > > > > > Check that there is no empty line after a fixes statement > > > > > > > > why? > > > > > > > This comment is given a lot on the netdev and rdma mailing lists when > > > patches are submitted with > > > an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just > > > another tag and should be kept > > > together with the other ones. > > > > So test that all signature blocks and Fixes do not have > > blank lines between them instead of just the "Fixes:" line. > > > > And if there is some specific ordering required, perhaps a > > test for that ordering should be added as well. > > I'm aware of only one request - Fixes above SOB.
Well, nack for the suggested patch. If there are signature blocks, then there should not be blank lines between entries and there should be a blank line before the signature block. The current documentation in Documentation/process/submitting-patches.rst doesn't state anything about blank lines above or below Fixes: lines.
