Hi Greg, On Wed, Aug 22, 2007 at 11:59:41AM -0700, Greg KH wrote: > On Wed, Aug 22, 2007 at 10:53:02AM -0500, Eric Van Hensbergen wrote: > > On 8/22/07, Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err)) > > > and it will not be happy about it. > > > > > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > > Cc: Andrew Morton <[EMAIL PROTECTED]> > > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > Signed-off-by: Willy Tarreau <[EMAIL PROTECTED]> > > Acked-by: Eric Van Hensbergen <[EMAIL PROTECTED]> > > > > This seems to be in the current code as well, I'll forward-port the patch... > > Huh? It's not already in mainline? Then how did it ever get into the > stable queue? > > Ugh.
Maybe someone sent it to stable@ and lkml at the same time and it got lost on the second (noisy) path ? Judging from the patch, it got merged about one month ago : [EMAIL PROTECTED]:2.6$ git log v2.6.20..2.6.22.x -- fs/9p/conv.c|cat commit b3b590287ca3c36e0a3fa28d626f126dd5226fc4 Author: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Thu Jul 19 17:27:22 2007 -0700 fs: 9p/conv.c error path fix When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err)) and it will not be happy about it. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> [EMAIL PROTECTED]:2.6$ git describe b3b590287ca3c36e0a3fa28d626f126dd5226fc4 v2.6.22.1-53-gb3b5902 But yes, I agree that it's very annoying when -stable contains patches that are not in mainline. Fortunately, we have careful reviewers to catch this when it happens ! Regards, Willy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/