On 13/05/2019 12:50, Andy Shevchenko wrote: > On Mon, May 13, 2019 at 12:29:51PM +0200, Daniel Lezcano wrote: >> Due to the complexity of the code and the difficulty to debug it, >> let's add some selftests to the framework in order to spot issues or >> regression at boot time when the runtime testing is enabled for this >> subsystem. >> >> This tests the circular buffer at the limits and validates: >> - the encoding / decoding of the values >> - the macro to browse the irq timings circular buffer >> - the function to push data in the circular buffer > >> kernel/irq/timings.c | 119 +++++++++++++++++++++++++++++++++++++++++++ > > Is it possible to have it in a separate C-file?
It is possible but I would like to keep the selftest in the same file in order to keep all the structures and functions self-contained. >> +config TEST_IRQ_TIMINGS >> + bool "IRQ timings selftest" > >> + default n > > This is already default. Right, thanks for the review. >> + depends on IRQ_TIMINGS >> + help >> + Enable this option to test the irq timings code on boot. >> + >> + If unsure, say N. > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
