On 8/15/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Guy Streeter wrote: > > On 6/1/06, James Pearson <[EMAIL PROTECTED]> wrote: > >> H. Peter Anvin wrote: > >>> I think this is the wrong approach. > >>> > >>> Many of these should probably be converted to seq_file, but in the > >>> particular case of environ, the right approach is to observe the fact > >>> that reading environ is just like reading /proc/PID/mem, except: > >>> > >>> a. the access restrictions are less strict, and > >>> b. there is a range restriction, which needs to be enforced, and > >>> c. there is an offset. > >>> > >>> Pretty much, take the guts from /proc/PID/mem and generalize it > >>> slightly, and you have the code that can run either /proc/PID/mem or > >>> /proc/PID/environ. > >> The following patch is based on the /proc/PID/mem code appears to work > >> fine. > >> > > > > This thread has gone stale. The PAGE_SIZE limit still exists. Is this > > solution acceptable? > > > > Can we avoid the code duplication? > >
I hope you're not asking me. I don't know the proc fs code well enough to re-write this. --Guy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
