On Sun, Aug 12, 2007 at 10:54:45AM -0400, Mathieu Desnoyers wrote:
> the #endif /* CONFIG_SMP */ should cover the default condition, or it may
> cause
> bad parameter to be silently missed.
>
> Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]>
> CC: [EMAIL PROTECTED]
> CC: [EMAIL PROTECTED]
> ---
> include/asm-m32r/system.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-lttng/include/asm-m32r/system.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/asm-m32r/system.h 2007-08-07
> 14:55:02.000000000 -0400
> +++ linux-2.6-lttng/include/asm-m32r/system.h 2007-08-07 14:57:57.000000000
> -0400
> @@ -189,9 +189,9 @@ __xchg(unsigned long x, volatile void *
> #endif /* CONFIG_CHIP_M32700_TS1 */
> );
> break;
> +#endif /* CONFIG_SMP */
> default:
> __xchg_called_with_bad_pointer();
> -#endif /* CONFIG_SMP */
> }
>
> local_irq_restore(flags);
It seems you never checked whether your patch compiles:
<-- snip -->
...
CC init/main.o
In file included from include2/asm/bitops.h:16,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/include/linux/bitops.h:9,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/include/linux/kernel.h:15,
from include2/asm/processor.h:16,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/include/linux/prefetch.h:14,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/include/linux/list.h:8,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/include/linux/module.h:9,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/init/main.c:13:
include2/asm/system.h: In function '__xchg':
include2/asm/system.h:191: error: implicit declaration of function
'__xchg_called_with_bad_pointer'
make[2]: *** [init/main.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
