On 2019/4/19 18:43, Robert Jarzmik wrote: > Zhou Wang <wangzh...@hisilicon.com> writes: > >> In function sg_split, the second sg_calculate_split will return -EINVAL >> when in_mapped_nents is 0. >> >> Indeed there is no need to do second sg_calculate_split and sg_split_mapped >> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in >> original sgl. >> >> Signed-off-by: Zhou Wang <wangzh...@hisilicon.com> > That's right. May I know what is the usecase which led you to this fix ?
I posted a patchset to support HiSilicon compression engine: https://lkml.org/lkml/2019/1/23/358. As Herber Xu suggested, it should use new crypto acomp API which uses sgl as data input and output. However, our hardware can not handle compress head for input/output data, so I need split input/output sgl firstly which is not mapped sgl. New version of HiSilicon compression engine driver has not been posted to community yet. I will do this later. > > Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Many thanks for your review, Zhou > > -- > Robert > > . >
