On Tue, 16 Apr 2019 at 10:00, Pavel Machek <pa...@ucw.cz> wrote: > > On Tue 2019-04-16 09:48:51, Ulf Hansson wrote: > > On Fri, 12 Apr 2019 at 11:34, Pavel Machek <pa...@ucw.cz> wrote: > > > > > > !voltage_ranges is tested for too late, allowing warning and undefined > > > behavior. Fix that. > > > > > > Signed-off-by: Pavel Machek <pa...@ucw.cz> > > > > Pavel, thanks for your patch. > > > > Would you mind re-posting to linux-mmc so I can get it into the > > patchtracker. Please also change the prefix of the header to "mmc: > > core:". > > Done.
Thanks! > > > > Plus I guess author should add parenthesis in the expression. a / b / > > > c is _not_ common idiom. > > Can you do something about the a / b / c situation? Sure. > > > > - num_ranges = num_ranges / sizeof(*voltage_ranges) / 2; > > > + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2; > > I guess it is: > num_ranges = (num_ranges / sizeof(*voltage_ranges)) / 2; Just send a patch on top, then I will apply it. Kind regards Uffe
