On Tue, 2007-08-14 at 14:28 -0700, Christoph Lameter wrote: > On Tue, 14 Aug 2007, Serge E. Hallyn wrote: > > > CONFIG_NODES_SHIFT was unset, so MAX_NUMNODES=1, so > > node_state() and node_set_state() are dummies. > > Ok then you did not have a NUMA system configured. So its okay for the > dummies to ignore the stuff. CONFIG_NODES_SHIFT is a constant and does not > change. The first bit is always set.
The first bit [node 0] is only set for the N_ONLINE [and N_POSSIBLE] mask. We could add the static init for the other masks, but since non-numa platforms are going through the __build_all_zonelists, they might as well set the MEMORY bits explicitly. Or, maybe you'll disagree ;-). Lee - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/