Re: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T

[Thomas Gleixner]

On Mon, 1 Apr 2019, Jian-Hong Pan wrote:
> +/*
> + * Some machines require the "reboot=e" commandline options
> + */
> +static int __init set_efi_reboot(const struct dmi_system_id *d)
> +{
> +     if (reboot_type != BOOT_EFI) {
> +             reboot_type = BOOT_EFI;

So if EFI is disabled in the kernel this will fall through to BOOT_BIOS. Is
that intended behaviour?

> +             pr_info("%s series board detected. Selecting %s-method for 
> reboot.\n",
> +                     d->ident, "EFI");

Is thee a reason not to write "EFI" in the string itself?

Thanks,

        tglx