On Tue, Apr 02, 2019 at 06:18:21PM -0700, Ray Jui wrote: > This patch series adds the following support to the iProc I2C driver: > - Increase maximum read transfer size to 255 bytes > - I2C slave mode > - Polling mode > - NIC I2C mode > > This patch series is based on kernel v5.1-rc3 and available at: > https://github.com/Broadcom/arm64-linux.git > branch: i2c-slave-v6 > > Changes from v5: > - Address various comments from Wolfram
In the future, please write in detail what you changed. I review so many
patches that I can't recall all my comments on every patch.
That being said, all patches applied to for-next, thanks!
Can be fixed incrementally, my code checkers complain about:
CPPCHECK
drivers/i2c/busses/i2c-bcm-iproc.c:720:14: warning: Shifting signed 32-bit
value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
val |= 1 << M_TX_WR_STATUS_SHIFT;
^
drivers/i2c/busses/i2c-bcm-iproc.c:847:13: warning: Shifting signed 32-bit
value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
^
drivers/i2c/busses/i2c-bcm-iproc.c:998:13: warning: Shifting signed 32-bit
value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
signature.asc
Description: PGP signature
