On Fri, 29 Mar 2019 at 20:28, Ezequiel Garcia
<ezequ...@vanguardiasur.com.ar> wrote:
>
> On Fri, 29 Mar 2019 at 18:55, Douglas Anderson <diand...@chromium.org> wrote:
> >
> > It appears that there is a typo in the rk3288 TRM. For
> > GRF_SOC_CON0[7] it says that 0 means "vepu" and 1 means "vdpu". It's
> > the other way around.
> >
> > How do I know? Here's my evidence:
> >
> > 1. Prior to commit 4d3e84f99628 ("clk: rockchip: describe aclk_vcodec
> > using the new muxgrf type on rk3288") we always pretended that we
> > were using "aclk_vdpu" and the comment in the code said that this
> > matched the default setting in the system. In fact the default
> > setting is 0 according to the TRM and according to reading memory
> > at bootup. In addition rk3288-based Chromebooks ran like this and
> > the video codecs worked.
> > 2. With the existing clock code if you boot up and try to enable the
> > new VIDEO_ROCKCHIP_VPU as a module (and without "clk_ignore_unused"
> > on the command line), you get errors like "failed to get ack on
> > domain 'pd_video', val=0x80208". After flipping vepu/vdpu things
> > init OK.
> > 3. If I export and add both the vepu and vdpu to the list of clocks
> > for RK3288_PD_VIDEO I can get past the power domain errors, but now
> > I freeze when the vpu_mmu gets initted.
> > 4. If I just mark the "vdpu" as IGNORE_UNUSED then everything boots up
> > and probes OK showing that somehow the "vdpu" was important to keep
> > enabled. This is because we were actually using it as a parent.
> > 5. After this change I can hack "aclk_vcodec_pre" to parent from
> > "aclk_vepu" using assigned-clocks and the video codec still probes
> > OK.
> >
> > Fixes: 4d3e84f99628 ("clk: rockchip: describe aclk_vcodec using the new
> > muxgrf type on rk3288")
> > Signed-off-by: Douglas Anderson <diand...@chromium.org>
> > ---
> > I currently have no way to test the JPEG mem2mem driver, so hopefully
> > others can test this and make sure it's happy for them. I'm just
> > happy not to get strange errors at boot anymore.
> >
>
> I won't have access to this hardware for a few days, but I am happy
> to provide a simple test tool.
>
> Still haven't reviewed this, but thanks for chasing it down!
>
Here's a simple tool that tests JPEG encoding. There are two branches,
with request API and without request API:
https://gitlab.collabora.com/ezequiel/v4l-jpeg
Usage is fairly simple, there's a test.sh that runs three tests,
writing three JPEG images.
You can also use v4l2jpegenc gstreamer element,
but it's slightly more involved to set up.
Hope it helps,
Eze
