On Thu, Mar 28, 2019 at 03:03:29PM +0100, Borislav Petkov wrote: > On Thu, Mar 28, 2019 at 03:50:15PM +0200, Andy Shevchenko wrote: > > Can, but with code uglifying to workaround kstrtox() restrictions. > > simple_strtox() _just works_ as expected. > > simple_strtox() also has its problems.
Yes! And point here: we do not care. > > Requires buffer copying, finding digits there, making a proper termination. > > And > > It needs a single kstrtoull() call to parse the port. No, it does not. It needs more as I described. Have you investigated a topic? Have you seen all possible combinations of input here? > And we have > kstrtoull() available in the compressed stage so pls do the conversion > ontop. If it's strong opinion, I consider this rather as NAK. Thank you for review. -- With Best Regards, Andy Shevchenko
