4.14-stable review patch. If anyone has any objections, please let me know.
------------------ From: Jules Maselbas <jules.masel...@arm.com> commit 1b5d43cfb69759d8ef8d30469cea31d0c037aed5 upstream. This patch prevents the 'global_tunables_lock' mutex from being unlocked before being locked. This mutex is not locked if the sugov_kthread_create() function fails. Signed-off-by: Jules Maselbas <jules.masel...@arm.com> Acked-by: Peter Zijlstra <pet...@infradead.org> Cc: Chris Redpath <chris.redp...@arm.com> Cc: Dietmar Eggermann <dietmar.eggem...@arm.com> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Mike Galbraith <efa...@gmx.de> Cc: Patrick Bellasi <patrick.bell...@arm.com> Cc: Stephen Kyle <stephen.k...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux-kernel@vger.kernel.org Cc: n...@arm.com Link: http://lkml.kernel.org/r/20180329144301.38419-1-jules.masel...@arm.com Signed-off-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- kernel/sched/cpufreq_schedutil.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -605,10 +605,9 @@ fail: stop_kthread: sugov_kthread_stop(sg_policy); - -free_sg_policy: mutex_unlock(&global_tunables_lock); +free_sg_policy: sugov_policy_free(sg_policy); disable_fast_switch:
