On Mon, Mar 04, 2019 at 03:50:50PM +0800, Yuantian Tang wrote:
> Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster
> sensor is used to monitor the temperature of core and SoC platform is for
> platform. The current dts only support the first sensor.
> This patch adds the second sensor node to dts to enable it.
> 
> Signed-off-by: Yuantian Tang <andy.t...@nxp.com>
> ---
> v3:
>       - use more descriptive name for each zone
> v2:
>       - Add more information about sensors to description
> PS: In order to keep consistency to the first thermal-zone node, there will
> be "WARNING: line over 80 characters" warnings.
> 
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi |   43 +++++++++++++++++++++--
>  1 files changed, 39 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 661137f..54f973b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -129,19 +129,19 @@
>       };
>  
>       thermal-zones {
> -             cpu_thermal: cpu-thermal {
> +             core_cluster_thermal {

We prefer to use hyphen instead of underscore in node name.

Shawn

>                       polling-delay-passive = <1000>;
>                       polling-delay = <5000>;
>                       thermal-sensors = <&tmu 0>;
>  
>                       trips {
> -                             cpu_alert: cpu-alert {
> +                             core_cluster_alert: core_cluster-alert {
>                                       temperature = <85000>;
>                                       hysteresis = <2000>;
>                                       type = "passive";
>                               };
>  
> -                             cpu_crit: cpu-crit {
> +                             core_cluster_crit: core_cluster-crit {
>                                       temperature = <95000>;
>                                       hysteresis = <2000>;
>                                       type = "critical";
> @@ -150,7 +150,42 @@
>  
>                       cooling-maps {
>                               map0 {
> -                                     trip = <&cpu_alert>;
> +                                     trip = <&core_cluster_alert>;
> +                                     cooling-device =
> +                                             <&cpu0 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu1 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu2 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu3 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu4 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu5 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu6 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> +                                             <&cpu7 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
> +             };
> +
> +             platform-thermal {
> +                     polling-delay-passive = <1000>;
> +                     polling-delay = <5000>;
> +                     thermal-sensors = <&tmu 1>;
> +
> +                     trips {
> +                             platform_alert: platform-alert {
> +                                     temperature = <85000>;
> +                                     hysteresis = <2000>;
> +                                     type = "passive";
> +                             };
> +
> +                             platform_crit: platform-crit {
> +                                     temperature = <95000>;
> +                                     hysteresis = <2000>;
> +                                     type = "critical";
> +                             };
> +                     };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&platform_alert>;
>                                       cooling-device =
>                                               <&cpu0 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
>                                               <&cpu1 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>,
> -- 
> 1.7.1
> 

Reply via email to