It was only called in the tasklet context. root@jeff:~/git/linux-next# git grep -in bnxt_qplib_service_nq drivers/infiniband/hw/bnxt_re/qplib_fp.c:236:static void bnxt_qplib_service_nq(unsigned long data) drivers/infiniband/hw/bnxt_re/qplib_fp.c:390: tasklet_init(&nq->worker, bnxt_qplib_service_nq,
thanks. Jason Gunthorpe <j...@ziepe.ca> 于2019年3月20日周三 上午3:22写道： > > On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote: > > It is unnecessary to call spin_lock_bh in a tasklet. > > > > Signed-off-by: Jeff Xie <chongguig...@gmail.com> > > --- > > drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > I'm curious, how did you prove this was always in a tasklet? > > Jason -- jeff
