It is unnecessary to call spin_lock_bh in a tasklet.

Signed-off-by: Jeff Xie <chongguig...@gmail.com>
---
 drivers/dma/xgene-dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c
index eafd6c4..0023236 100644
--- a/drivers/dma/xgene-dma.c
+++ b/drivers/dma/xgene-dma.c
@@ -703,7 +703,7 @@ static void xgene_dma_cleanup_descriptors(struct 
xgene_dma_chan *chan)
 
        INIT_LIST_HEAD(&ld_completed);
 
-       spin_lock_bh(&chan->lock);
+       spin_lock(&chan->lock);
 
        /* Clean already completed and acked descriptors */
        xgene_dma_clean_completed_descriptor(chan);
@@ -772,7 +772,7 @@ static void xgene_dma_cleanup_descriptors(struct 
xgene_dma_chan *chan)
         */
        xgene_chan_xfer_ld_pending(chan);
 
-       spin_unlock_bh(&chan->lock);
+       spin_unlock(&chan->lock);
 
        /* Run the callback for each descriptor, in order */
        list_for_each_entry_safe(desc_sw, _desc_sw, &ld_completed, node) {
-- 
2.7.4

Reply via email to