On Sunday 12 August 2007 10:59, Linus Torvalds wrote: > On Sun, 12 Aug 2007, Linus Torvalds wrote: > > Hmm. Patch looks ok, I just wonder what started triggering this for you? > > Oh. It's the "Make patching more robust" commit.
No it should have been the earlier text_poke change which first started using mempcy in that path. > "Robust" my ass. > > We used to just copy the replacement in one go (works fine, since it just > overwrote the two first bytes), and then "nop_out()" the rest (works fine, > since it didn't matter for memcpy). > > That whole commit looks a bit dubious. It also adds a 254-byte stack > usage (anything actually even close to that big?). Gaah. The x86-64 copy_user copies the whole function as alternative and it is over 200 bytes. The original patch had a smaller buffer and cause x86-64 to BUG at boot -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
