> Make both variables static. "pti_set_kernel_image_nonglobal(void)" is an awfully funny looking variable. ;)
> Signed-off-by: Valdis Kletnieks <[email protected]> > > --- > diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c > index 4fee5c3003ed..139b28a01ce4 100644 > --- a/arch/x86/mm/pti.c > +++ b/arch/x86/mm/pti.c > @@ -77,7 +77,7 @@ static void __init pti_print_if_secure(const char *reason) > pr_info("%s\n", reason); > } > > -enum pti_mode { > +static enum pti_mode { I'm struggling to figure out why we would want to do this. If there's a really good reason, I think we probably need to do it en masse: $ grep -r '^enum.{' arch/x86/ | wc -l 48 > PTI_AUTO = 0, > PTI_FORCE_OFF, > PTI_FORCE_ON > @@ -602,7 +602,7 @@ static void pti_clone_kernel_text(void) > set_memory_global(start, (end_global - start) >> PAGE_SHIFT); > } > > -void pti_set_kernel_image_nonglobal(void) > +static void pti_set_kernel_image_nonglobal(void) Yes, this function should be static.
