5.0-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Thierry Reding <tred...@nvidia.com>

commit 0326ccb5feac6eac35ba6254260e2774277cd976 upstream.

During initialization, the host and super-speed power domains will
contain an ERR_PTR() encoded error code rather than being NULL. To
avoid a crash, use a !IS_ERR_OR_NULL() condition during cleanup.

Signed-off-by: Thierry Reding <tred...@nvidia.com>
Fixes: 6494a9ad86de ("usb: xhci: tegra: Add genpd support")
Cc: stable <sta...@vger.kernel.org>
Reviewed-by: Jon Hunter <jonath...@nvidia.com>
Acked-by: Mathias Nyman <mathias.ny...@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/usb/host/xhci-tegra.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -941,9 +941,9 @@ static void tegra_xusb_powerdomain_remov
                device_link_del(tegra->genpd_dl_ss);
        if (tegra->genpd_dl_host)
                device_link_del(tegra->genpd_dl_host);
-       if (tegra->genpd_dev_ss)
+       if (!IS_ERR_OR_NULL(tegra->genpd_dev_ss))
                dev_pm_domain_detach(tegra->genpd_dev_ss, true);
-       if (tegra->genpd_dev_host)
+       if (!IS_ERR_OR_NULL(tegra->genpd_dev_host))
                dev_pm_domain_detach(tegra->genpd_dev_host, true);
 }
 


Reply via email to