Hi Mark, > On Mon, Mar 04, 2019 00:05:00, Mark Brown wrote: > > On Thu, Feb 28, 2019 at 01:25:42PM +0000, Gareth Williams wrote: > > From: Phil Edworthy <phil.edwor...@renesas.com> > > > > The Synopsys SSI Controller has an interface clock, but most SoCs hide > > this away. However, on some SoCs you need to explicity enable the > > interface clock in order to access the registers. Therefore, add > > support for an optional interface clock. > > This doesn't build for me: > > CC drivers/spi/spi-dw-mmio.o > drivers/spi/spi-dw-mmio.c: In function ‘dw_spi_mmio_probe’: > drivers/spi/spi-dw-mmio.c:177:18: error: implicit declaration of function > ‘devm_clk_get_optional’; did you mean ‘devm_gpiod_get_optional’? [- > Werror=implicit-function-declaration] > dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); > ^~~~~~~~~~~~~~~~~~~~~ > devm_gpiod_get_optional > drivers/spi/spi-dw-mmio.c:177:16: warning: assignment to ‘struct clk *’ from > ‘int’ makes pointer from integer without a cast [-Wint-conversion] > dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); > ^ Sorry, I should have noted the dependency for the patch below. I will add this into the next version. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/clk/clk-devres.c?h=next-20190304&id=60b8f0ddf1a927ef02141a6610fd52575134f821
Kind Regards, Gareth Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
