On 04/03/19 12:10, Xiaoyao Li wrote: > Like you said before, I think we don't need the condition judgment > "if(boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT))", but to set > F(CORE_CAPABILITY) > always for guest since MSR_IA32_CORE_CAPABILITY is emulated. > > And we should set the right emulated value of MSR_IA32_CORE_CAPABILITY for > guest > in function kvm_get_core_capability() based on whether > boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT) just as you commented in the next > patch.
Yes, that would certainly be better. However, you'd also have to move MSR_IA32_CORE_CAPABILITY handling to x86.c, because you'd have to enable X86_FEATURE_CORE_CAPABILITY for AMD. Paolo
