On 2/25/19 6:03 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 25, 2019 at 09:07:03AM +0200, Adrian Hunter escreveu: >> On 23/02/19 1:06 AM, Tony Jones wrote: >>> Support both Python2 and Python3 in the intel-pt-events.py script >>> >>> There may be differences in the ordering of output lines due to >>> differences in dictionary ordering etc. However the format within lines >>> should be unchanged. >>> >>> Fix space/tab inconsistency as python3 enforces consistency. >> >> It would be better for the white space changes to be a separate patch. >> >> But I am not in favour of using spaces instead of tabs because it is the >> opposite of what we tend to do with C. >> >> Arnaldo, can you provide a guideline on this? > > Yeah, please separate things, this would help me now to pick the > uncontroversial part while we discuss the other. > > And I'm in favour of being consistent with what we do for C code, i.e. > use TABs. > > I'm now processing the other patches.
I'll split and resubmit. Also, FYI, PEP8 states "Spaces are the preferred indentation method".
