On Thu, Feb 21, 2019 at 02:23:30PM -0800, Andi Kleen wrote: > On Thu, Feb 21, 2019 at 10:41:32AM +0100, Jiri Olsa wrote: > > And display the error message from removing > > the old data file: > > > > $ perf record ls > > Can't remove old data: Permission denied (perf.data.old) > > Perf session creation failed. > > > > Not sure how to make fail the rename (after we successfully > > remove the destination file/dir) to show the message, > > anyway let's have it there. > > The use of rm_rf is really scary. So I simple command line typo could turn > this into rm -rf / ? > > Please add some sanity checks to not remove multiple levels, > and only remove files which look like they are generated > by perf.
right, will do jirka