Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

[Pierre Morel]

On 19/02/2019 10:44, Christian Borntraeger wrote:

On 19.02.2019 10:22, Cornelia Huck wrote:

On Mon, 18 Feb 2019 19:08:48 +0100
Pierre Morel <pmo...@linux.ibm.com> wrote:

...snip...

+static struct bus_type matrix_bus = {
+       .name = "vfio_ap",
+       .match = &matrix_bus_match,
+};
+
+static int matrix_probe(struct device *dev)
+{
+       return 0;
+}

I don't think you need this (the important function is the match
function of the bus).

Yes, with

diff --git a/drivers/s390/crypto/vfio_ap_drv.c 
b/drivers/s390/crypto/vfio_ap_drv.c
index 8e45559795429..8ceec41afe322 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -68,15 +68,9 @@ static struct bus_type matrix_bus = {
         .match = &matrix_bus_match,
  };

-static int matrix_probe(struct device *dev)

-{
-       return 0;
-}
-
  static struct device_driver matrix_driver = {
         .name = "vfio_ap",
         .bus = &matrix_bus,
-       .probe = matrix_probe,
  };

static int vfio_ap_matrix_dev_create(void)

on top things still look fine.

OK, simpler is better, I remove the probe.

Thanks,
Pierre

--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany