On Wed, Feb 20, 2019 at 03:10:44PM -0800, Palmer Dabbelt wrote: > On Wed, 20 Feb 2019 06:20:48 PST (-0800), yury.no...@gmail.com wrote: > > On Wed, Feb 20, 2019 at 03:52:36PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 20, 2019 at 03:51:01PM +0200, Andy Shevchenko wrote: > > > > On Wed, Feb 20, 2019 at 11:37:03AM +0300, Yury Norov wrote: > > > > > test_bitmap_parselist currently uses get_cycles which is not > > > > > implemented on some platforms, so use ktime_get() instead. > > > > > > > > This sounds like a fix that should go first in the series. > > > > > > Ah, okay, it's already first for test module. > > > Perhaps Fixes tag and actually one or more examples of such architectures? > > > > Hi Andy, thanks for your time on it. > > > > Only arm, arm64, openrisc, riscv and sparc64 #define get_cycles. > > So IIUC, others take stub from include/asm-generic/timex.h. > > Should we (RISC-V) be doing something else? It seems odd to be in such a > minority here, but we do have a ISA-mandated timer so the get_cycles() > implementation is super easy.
I think you are completely fine because you are one of those who implement get_cycles(). get_cycles() is the problem for those who use it in generic code because their code surprisingly gets broken on some machines while works OK on others. This is not a problem of any specific arch. For long term, we should inspect the non-arch code and replace get_cycles() with ktime_get() where appropriate, and avoid introducing new get_cycles() uses. > > sparc32, xtensa, m68k, um, and in some cases x86, mips and nios2 > > provide zero-stubs explicitly. > > > > Yury > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > >
