Re-use the "tps65218_pmic_*_current_limit()" functions of LS3
and calculate the different required bit-shift by counting the
trailing 0s in "struct regulator_desc.csel_mask"

Signed-off-by: Christian Hohnstaedt <christian.hohnsta...@wago.com>
---
 drivers/regulator/tps65218-regulator.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/regulator/tps65218-regulator.c 
b/drivers/regulator/tps65218-regulator.c
index 5dd559e..95708d3 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -205,7 +205,8 @@ static int tps65218_pmic_set_input_current_lim(struct 
regulator_dev *dev,
                return -EINVAL;
 
        return tps65218_set_bits(tps, dev->desc->csel_reg, dev->desc->csel_mask,
-                                index << 2, TPS65218_PROTECT_L1);
+                                index << __builtin_ctz(dev->desc->csel_mask),
+                                TPS65218_PROTECT_L1);
 }
 
 static int tps65218_pmic_set_current_limit(struct regulator_dev *dev,
@@ -224,7 +225,8 @@ static int tps65218_pmic_set_current_limit(struct 
regulator_dev *dev,
                return -EINVAL;
 
        return tps65218_set_bits(tps, dev->desc->csel_reg, dev->desc->csel_mask,
-                                index << 2, TPS65218_PROTECT_L1);
+                                index << __builtin_ctz(dev->desc->csel_mask),
+                                TPS65218_PROTECT_L1);
 }
 
 static int tps65218_pmic_get_current_limit(struct regulator_dev *dev)
@@ -237,12 +239,13 @@ static int tps65218_pmic_get_current_limit(struct 
regulator_dev *dev)
        if (retval < 0)
                return retval;
 
-       index = (index & dev->desc->csel_mask) >> 2;
+       index = (index & dev->desc->csel_mask) >>
+                                        __builtin_ctz(dev->desc->csel_mask);
 
        return ls3_currents[index];
 }
 
-static struct regulator_ops tps65218_ls3_ops = {
+static struct regulator_ops tps65218_ls23_ops = {
        .is_enabled             = regulator_is_enabled_regmap,
        .enable                 = tps65218_pmic_enable,
        .disable                = tps65218_pmic_disable,
@@ -304,8 +307,13 @@ static const struct regulator_desc regulators[] = {
                           TPS65218_ENABLE2_LDO1_EN, 0, 0, ldo1_dcdc3_ranges,
                           2, 0, 0, TPS65218_REG_SEQ6,
                           TPS65218_SEQ6_LDO1_SEQ_MASK),
+       TPS65218_REGULATOR("LS2", "regulator-ls2", TPS65218_LS_2,
+                          REGULATOR_CURRENT, tps65218_ls23_ops, 0, 0, 0,
+                          TPS65218_REG_ENABLE2, TPS65218_ENABLE2_LS2_EN,
+                          TPS65218_REG_CONFIG2, TPS65218_CONFIG2_LS2ILIM_MASK,
+                          NULL, 0, 0, 0, 0, 0),
        TPS65218_REGULATOR("LS3", "regulator-ls3", TPS65218_LS_3,
-                          REGULATOR_CURRENT, tps65218_ls3_ops, 0, 0, 0,
+                          REGULATOR_CURRENT, tps65218_ls23_ops, 0, 0, 0,
                           TPS65218_REG_ENABLE2, TPS65218_ENABLE2_LS3_EN,
                           TPS65218_REG_CONFIG2, TPS65218_CONFIG2_LS3ILIM_MASK,
                           NULL, 0, 0, 0, 0, 0),
-- 
2.7.4

Reply via email to