On 08/07, Venki Pallipadi wrote: > > On Tue, Aug 07, 2007 at 07:13:36PM +0400, Oleg Nesterov wrote: > > > > As for kthread_bind(), I think wait_task_inactive+set_task_cpu is just > > an optimization, and easy to "fix": > > > > --- kernel/kthread.c 2007-07-28 16:58:17.000000000 +0400 > > +++ /proc/self/fd/0 2007-08-07 18:56:54.248073547 +0400 > > @@ -166,10 +166,7 @@ void kthread_bind(struct task_struct *k, > > WARN_ON(1); > > return; > > } > > - /* Must have done schedule() in kthread() before we set_task_cpu */ > > - wait_task_inactive(k); > > - set_task_cpu(k, cpu); > > - k->cpus_allowed = cpumask_of_cpu(cpu); > > + set_cpus_allowed(current, cpumask_of_cpu(cpu)); > > } > > EXPORT_SYMBOL(kthread_bind); > > > > Not sure whether set_cpus_allowed() will work here. Looks like, it needs the > CPU to be online during the call and in kthread_bind() case CPU may be > offline.
Aah, you are right, of course. Thanks, Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
