On Thu, Feb 14, 2019 at 10:10 AM Kees Cook <keesc...@chromium.org> wrote:> > We certainly can, but we'll still need to fix the "don't exec a > truncated interpreter path" problem (which this fixes). > > I'm happy to do it as two steps instead: revert, then a separate fix > to land in the merge window?
I think that's better. It should also be fairly easy: just look for whitespace in the truncated output (in the place where we already check for the "oh, we truncated") It's even possible that somebody depends on a truncated interpreter executable name. Unlikely, but possiible. So I'd rather just revert, and re-try the smaller approach for 5.1. Linus