On 14-02-19, 01:54, Anson Huang wrote:
> Add i.MX8QXP CPU opp table to support cpufreq.
> 
> Signed-off-by: Anson Huang <anson.hu...@nxp.com>
> ---
> No change since V3.
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 4021f25..593e2db 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -34,6 +34,10 @@
>                       reg = <0x0 0x0>;
>                       enable-method = "psci";
>                       next-level-cache = <&A35_L2>;
> +                     clocks = <&clk IMX_A35_CLK>;
> +                     clock-latency = <61036>;

Who uses this value ? And why is it different from the one mentioned
in the OPP table ?

> +                     #cooling-cells = <2>;

clocks and cooling-cells must be defined for all the CPUs.

> +                     operating-points-v2 = <&a35_0_opp_table>;
>               };
>  
>               A35_1: cpu@1 {
> @@ -42,6 +46,7 @@
>                       reg = <0x0 0x1>;
>                       enable-method = "psci";
>                       next-level-cache = <&A35_L2>;
> +                     operating-points-v2 = <&a35_0_opp_table>;
>               };
>  
>               A35_2: cpu@2 {
> @@ -50,6 +55,7 @@
>                       reg = <0x0 0x2>;
>                       enable-method = "psci";
>                       next-level-cache = <&A35_L2>;
> +                     operating-points-v2 = <&a35_0_opp_table>;
>               };
>  
>               A35_3: cpu@3 {
> @@ -58,6 +64,7 @@
>                       reg = <0x0 0x3>;
>                       enable-method = "psci";
>                       next-level-cache = <&A35_L2>;
> +                     operating-points-v2 = <&a35_0_opp_table>;
>               };
>  
>               A35_L2: l2-cache0 {
> @@ -65,6 +72,24 @@
>               };
>       };
>  
> +     a35_0_opp_table: opp-table {
> +             compatible = "operating-points-v2";
> +             opp-shared;
> +
> +             opp-900000000 {
> +                     opp-hz = /bits/ 64 <900000000>;
> +                     opp-microvolt = <1000000>;
> +                     clock-latency-ns = <150000>;
> +             };
> +
> +             opp-1200000000 {
> +                     opp-hz = /bits/ 64 <1200000000>;
> +                     opp-microvolt = <1100000>;
> +                     clock-latency-ns = <150000>;
> +                     opp-suspend;

You want to go to a higher frequency on suspend ?

> +             };
> +     };
> +
>       gic: interrupt-controller@51a00000 {
>               compatible = "arm,gic-v3";
>               reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
> -- 
> 2.7.4

-- 
viresh

Reply via email to