On Tue, Feb 12, 2019 at 09:08:41AM +0100, Jiri Slaby wrote: > On 12. 02. 19, 8:51, Greg Kroah-Hartman wrote: > > On Mon, Feb 11, 2019 at 02:25:33PM +0100, Christoph Hellwig wrote: > >> Hi Greg and Jiri, > >> > >> I've been working hard to get rid of the remaining callers the pass a > >> NULL struct device to the DMA mapping functions and am almost done. > >> > >> The only non-trivial driver is the synclink driver, which has legacy > >> early 90s style ISA support that doesn't use the device model at all. > >> > >> In theory we could convert it to an isa_driver, but without testing > >> that seems rather dangerous. So for now I would suggest that we > >> remove the ISA support in this driver - if anyone cares enough we > >> can resurrect it from the git history and convert it to use the driver > >> model. > > > > No objection from me at all, I'll go queue this up now, thanks. > > Agreed, but I would kill also the MGSL_BUS_TYPE_ISA macro proper.
It's just a #define, in a uapi file, so we should probably leave it as userspace programs _might_ depend on it. I have no idea why, but oh well... thanks, greg k-h
