Quoting Jiaxun Yang (2019-01-31 22:35:38) > diff --git a/drivers/clk/loongson1/Kconfig b/drivers/clk/loongson1/Kconfig > new file mode 100644 > index 000000000000..e2220332d797 > --- /dev/null > +++ b/drivers/clk/loongson1/Kconfig > @@ -0,0 +1,27 @@ > +menu "Loongson-1 Clock drivers" > + depends on MACH_LOONGSON32 > + > +config LOONGSON1_CLOCK_COMMON > + bool > + > +config LOONGSON1_CLOCK_LS1B > + bool "Loongson 1B driver" > + default y
Should be default CONFIG_LOONGSON1_LS1B? > + select LOONGSON1_CLOCK_COMMON Drop the selects and have the menuconfig make the "COMMON" config option enabled then? > + help > + Support the clocks provided by the clock hardware on Loongson-1B > + and compatible SoCs. > + > + If building for a Loongson-1B SoC, you want to say Y here. > + > +config LOONGSON1_CLOCK_LS1C > + bool "Loongson 1C driver" > + default y And default CONFIG_LOONGSON1_LS1C? > + select LOONGSON1_CLOCK_COMMON > + help > + Support the clocks provided by the clock hardware on Loongson-1C > + and compatible SoCs. > + > + If building for a Loongson-1C SoC, you want to say Y here. > + > +endmenu
