Hi Axel,
On Wed, 30 Jan 2019 15:11:09 +0800 <axel....@ingics.com> wrote:
> Ensure unwind all resources if probe fails.
>
> Signed-off-by: Axel Lin <axel....@ingics.com>
> ---
> drivers/regulator/uniphier-regulator.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/uniphier-regulator.c
> b/drivers/regulator/uniphier-regulator.c
> index abf22acbd13e..6ba0ae405f2b 100644
> --- a/drivers/regulator/uniphier-regulator.c
> +++ b/drivers/regulator/uniphier-regulator.c
> @@ -87,8 +87,10 @@ static int uniphier_regulator_probe(struct platform_device
> *pdev)
> }
>
> regmap = devm_regmap_init_mmio(dev, base, priv->data->regconf);
> - if (IS_ERR(regmap))
> - return PTR_ERR(regmap);
> + if (IS_ERR(regmap)) {
> + ret = PTR_ERR(regmap);
> + goto out_rst_assert;
> + }
Surely this return without asserting resets is wrong. This looks good to me.
Reviewed-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Thank you,
---
Best Regards,
Kunihiko Hayashi
