> On Aug 2 2007 16:04, Alexey Dobriyan wrote: > >On 8/2/07, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > >> fooptr = kmalloc(sizeof(struct foo), ...); > > > >Key word is "traditional". Good traditional form which even half-competent > >C programmers immediately parse in retina. > > And being aware of the potential type-unsafety makes programmers more > careful IMHO.
That's a _really_ good reason ;) > >> +/** > >> + * alloc_struct - allocate given type object > >> + * @type: the type of the object to allocate > >> + * @flags: the type of memory to allocate. > >> + */ > >> +#define alloc_struct(type, flags) ((type *) kmalloc(sizeof(type), flags)) > > >someone will write alloc_struct(int, GFP_KERNEL), I promise. > > and someone else will write > > struct complexthing foo; > alloc_struct(foo, GFP_KERNEL); And the compiler will complain like mad about that. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
